ajantha-bhat commented on a change in pull request #3871:
URL: https://github.com/apache/carbondata/pull/3871#discussion_r487850404



##########
File path: 
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonTableCompactor.scala
##########
@@ -373,11 +381,7 @@ class CarbonTableCompactor(carbonLoadModel: 
CarbonLoadModel,
       } else {
         true
       }
-      // here either of the conditions can be true, when delete segment is 
fired after compaction
-      // has started, statusFileUpdation will be false , but at the same time 
commitComplete can be

Review comment:
       the existing comment in the code was that, why we need to consider both 
the flag. Now only one flag is there. so, it is understandable. 
   
   Based on new code if it is not understandable and if you have any suggestion 
for comment, you can give here. I will add. 
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to