[GitHub] [carbondata] akashrn5 commented on a change in pull request #3923: [CARBONDATA-3984] 1. Compaction on table having range column after altering datatype from string to long string fails. 2. Validation of altering sort_column to long_string_column fails.

[GitBox]

akashrn5 commented on a change in pull request #3923:
URL: https://github.com/apache/carbondata/pull/3923#discussion_r488574809



##########
File path: 
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/longstring/VarcharDataTypesBasicTestCase.scala
##########
@@ -110,6 +110,21 @@ class VarcharDataTypesBasicTestCase extends QueryTest with 
BeforeAndAfterEach wi
     assert(exceptionCaught.getMessage.contains("its data type is not string"))
   }
 
+  test("cannot alter sort_columns dataType to long_string_columns") {

Review comment:
       please add test case for compaction failure case




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org