ajantha-bhat commented on a change in pull request #3943:
URL: https://github.com/apache/carbondata/pull/3943#discussion_r491943250
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/directread/ColumnarVectorWrapperDirectWithDeleteDelta.java
##########
@@ -58,6 +58,17 @@ public void putBoolean(int rowId, boolean value) {
}
}
+ @Override
Review comment:
please check and handle for
`ColumnarVectorWrapperDirectWithInvertedIndex`,
`ColumnarVectorWrapperDirectWithDeleteDeltaAndInvertedIndex` also
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/directread/ColumnarVectorWrapperDirectWithDeleteDeltaAndInvertedIndex.java
##########
@@ -78,6 +80,17 @@ public void putNull(int rowId) {
}
}
+ @Override
+ public void putObject(int rowId, Object obj) {
+ if (!deletedRows.get(rowId)) {
+ if (nullBits.get(rowId)) {
+ columnVector.putNull(counter++);
Review comment:
can you locally test one table with inverted index, I think here should
not use `counter`, may be ned to use `rowId`, convert function is having
`counter` already
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/directread/ColumnarVectorWrapperDirectWithDeleteDeltaAndInvertedIndex.java
##########
@@ -78,6 +80,17 @@ public void putNull(int rowId) {
}
}
+ @Override
+ public void putObject(int rowId, Object obj) {
+ if (!deletedRows.get(rowId)) {
+ if (nullBits.get(rowId)) {
+ columnVector.putNull(counter++);
Review comment:
can you locally test one table with inverted index, I think here should
not use `counter`, may be need to use `rowId`, convert function is having
`counter` already
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
