[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3951: [CARBONDATA-4005] SI with cache level blocklet issue

[GitBox]

ShreelekhyaG commented on a change in pull request #3951:
URL: https://github.com/apache/carbondata/pull/3951#discussion_r493201285



##########
File path: 
core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java
##########
@@ -648,11 +648,20 @@ public static String getShortBlockId(String blockId) {
             .replace(DATA_PART_PREFIX, "").replace(CARBON_DATA_EXT, "");
     // to remove compressor name
     if (!blockId.equalsIgnoreCase(blockIdWithCompressorName)) {
-      int index = blockIdWithCompressorName.lastIndexOf(".");
+      int index = blockIdWithCompressorName.lastIndexOf(POINT);
+      int fileSeperatorIndex = 
blockIdWithCompressorName.lastIndexOf(File.separator);
       if (index != -1) {
-        String replace =
-            
blockIdWithCompressorName.replace(blockIdWithCompressorName.substring(index), 
"");
-        return replace;
+        String modifiedBlockId;

Review comment:
       We could use the same method for both partition and non-partition case. 
So removed `getShortBlockIdForPartitionTable `method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org