kunal642 commented on a change in pull request #3953:
URL: https://github.com/apache/carbondata/pull/3953#discussion_r494046607
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecutorImpl.java
##########
@@ -138,6 +145,8 @@ public
RowLevelFilterExecutorImpl(List<DimColumnResolvedFilterInfo> dimColEvalua
this.exp = exp;
this.tableIdentifier = tableIdentifier;
this.complexDimensionInfoMap = complexDimensionInfoMap;
+ this.dateDictionaryGenerator =
+
DirectDictionaryKeyGeneratorFactory.getDirectDictionaryGenerator(DataTypes.DATE);
Review comment:
this issue is not happening with timestamp column?
##########
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/filterexpr/TestInFilter.scala
##########
@@ -165,8 +168,27 @@ class TestInFilter extends QueryTest with
BeforeAndAfterAll{
Seq(Row(4, 1.00, 2.00, 3.00)))
}
- override def afterAll(): Unit = {
+ test("test infilter with date, timestamp columns") {
+ sql("create table test_table(i int, dt date, ts timestamp) stored as
carbondata")
+ sql("insert into test_table select 1, '2020-03-30', '2020-03-30 10:00:00'")
Review comment:
drop table before create to avoid failure if previous test fails
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
