Kejian-Li commented on a change in pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#discussion_r495732821
########## File path: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java ########## @@ -421,6 +421,12 @@ public boolean createNewFile(final FsPermission permission) throws IOException { return file.createNewFile(); } + @Override + public boolean createNewFile(Boolean overwrite, final FsPermission permission) Review comment: It is goog to change Boolean to boolean ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org