akashrn5 commented on a change in pull request #3962:
URL: https://github.com/apache/carbondata/pull/3962#discussion_r498175600
##########
File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java
##########
@@ -1881,7 +1881,9 @@ public static TableInfo
convertGsonToTableInfo(Map<String, String> properties) {
gsonBuilder.registerTypeAdapter(DataType.class, new DataTypeAdapter());
Gson gson = gsonBuilder.create();
- TableInfo tableInfo = gson.fromJson(builder.toString(), TableInfo.class);
+ // if the column name contains backslash in the column name, then fromJson
will remove that,
+ // so replace like below to keep the "\" in column name and write the
proper name in the schema
+ TableInfo tableInfo = gson.fromJson(builder.toString().replace("\\",
"\\\\"), TableInfo.class);
Review comment:
actually `QueryTest ` has spark session without `carbonSession`, and we
cannot create another `sparkSession `when one is running. In example we cant
add as test case, so i think since i have added the proper comment, it should
be fine i guess.
##########
File path:
index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestSIWithSecondryIndex.scala
##########
@@ -423,6 +423,17 @@ class TestSIWithSecondryIndex extends QueryTest with
BeforeAndAfterAll {
sql("drop table table2")
}
+ test("test SI creation with special char column") {
+ sql("drop table if exists special_char")
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
