Indhumathi27 commented on a change in pull request #3969:
URL: https://github.com/apache/carbondata/pull/3969#discussion_r501492611
##########
File path: docs/dml-of-carbondata.md
##########
@@ -43,6 +43,7 @@ CarbonData DML statements are documented here,which includes:
**NOTE**:
* Use 'file://' prefix to indicate local input files path, but it just
supports local mode.
* If run on cluster mode, please upload all input files to distributed
file system, for example 'hdfs://' for hdfs.
+ * Each load creates new segment folder and manages the folder through
tablestatus file.
Review comment:
since this content is already present in Segment Management. no need to
add it
##########
File path: docs/dml-of-carbondata.md
##########
@@ -303,6 +304,7 @@ CarbonData DML statements are documented here,which
includes:
* The data type of source and destination table columns should be same
* INSERT INTO command does not support partial success if bad records are
found, it will fail.
* Data cannot be loaded or updated in source table while insert from source
table to target table is in progress.
+ * Each insert creates new segment folder and manages the folder through
tablestatus file.
Review comment:
same comment as above
##########
File path: docs/dml-of-carbondata.md
##########
@@ -43,6 +43,7 @@ CarbonData DML statements are documented here,which includes:
**NOTE**:
* Use 'file://' prefix to indicate local input files path, but it just
supports local mode.
* If run on cluster mode, please upload all input files to distributed
file system, for example 'hdfs://' for hdfs.
+ * Each load creates new segment folder and manages the folder through
tablestatus file.
Review comment:
since this content is already present in Segment Management. no need to
add it. If needed can update the first line in Segment Management
##########
File path: docs/dml-of-carbondata.md
##########
@@ -402,6 +404,11 @@ CarbonData DML statements are documented here,which
includes:
## UPDATE AND DELETE
+ Since the data in CarbonData files is immutable, the updates and delete are
done via maintaining two files namely:
Review comment:
Can update the line based on filesystem. Like, ` Since the data stored
in file system like HDFS is immutable,..`
##########
File path: docs/dml-of-carbondata.md
##########
@@ -454,6 +461,10 @@ CarbonData DML statements are documented here,which
includes:
Review comment:
Can specify without providing expression, it will delete all records
from table
##########
File path: docs/dml-of-carbondata.md
##########
@@ -447,13 +452,17 @@ CarbonData DML statements are documented here,which
includes:
### DELETE
- This command allows us to delete records from CarbonData table.
+ This command allows us to delete records from CarbonData table. Without
providing expression, it will delete all the records from table.
Review comment:
this can be added after syntax, as a note
##########
File path: docs/dml-of-carbondata.md
##########
@@ -402,6 +402,11 @@ CarbonData DML statements are documented here,which
includes:
## UPDATE AND DELETE
+ Since the data stored in file system like HDFS is immutable, the update and
delete in carbondata are done via maintaining two files namely:
Review comment:
```suggestion
Since the data stored in a file system like HDFS is immutable, the update
and delete in carbondata are done via maintaining two files namely:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
