[GitHub] [carbondata] QiangCai commented on a change in pull request #3950: [CARBONDATA-3889] Enable scalastyle check for all scala test code

[GitBox]

QiangCai commented on a change in pull request #3950:
URL: https://github.com/apache/carbondata/pull/3950#discussion_r504467105



##########
File path: 
integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataWithCompression.scala
##########
@@ -528,8 +571,9 @@ class TestLoadDataWithCompression extends QueryTest with 
BeforeAndAfterEach with
     var exception = intercept[RuntimeException] {
       loadData()
     }
+    // scalastyle:off lineLength
     assertResult("For not carbondata native supported compressor, the result 
of method getName() should be the full class name. Expected 
'org.apache.carbondata.core.datastore.compression.ZstdCompressor', found 
'zstd'")(exception.getMessage)
-
+    // scalastyle:on lineLength

Review comment:
       done

##########
File path: 
integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/emptyrow/TestSkipEmptyLines.scala
##########
@@ -33,50 +33,65 @@ class TestSkipEmptyLines extends QueryTest with 
BeforeAndAfterAll {
   test("test load options with true") {
     sql("drop table if exists skipEmptyRowCarbonTable")
     sql("CREATE TABLE skipEmptyRowCarbonTable (name string, age int) STORED AS 
carbondata")
-    sql(s"LOAD DATA LOCAL INPATH '$resourcesPath/emptylines.csv' into table 
skipEmptyRowCarbonTable " +
-        s"OPTIONS('skip_empty_line'='true')")
-    checkAnswer(sql("select * from skipEmptyRowCarbonTable"), 
Seq(Row("a",25),Row("b",22),Row("c",23)))
+    sql(s"LOAD DATA LOCAL INPATH '$resourcesPath/emptylines.csv' " +
+        "into table skipEmptyRowCarbonTable OPTIONS('skip_empty_line'='true')")
+    checkAnswer(sql("select * from skipEmptyRowCarbonTable"),
+      Seq(Row("a", 25), Row("b", 22), Row("c", 23)))
   }
 
   test("test load options with false") {
     sql("drop table if exists skipEmptyRowCarbonTable")
     sql("CREATE TABLE skipEmptyRowCarbonTable (name string, age int) STORED AS 
carbondata")
-    sql(s"LOAD DATA LOCAL INPATH '$resourcesPath/emptylines.csv' into table 
skipEmptyRowCarbonTable " +
-        s"OPTIONS('skip_empty_line'='false')")
+    sql(s"LOAD DATA LOCAL INPATH '$resourcesPath/emptylines.csv' " +
+        "into table skipEmptyRowCarbonTable 
OPTIONS('skip_empty_line'='false')")
     checkAnswer(sql("select * from skipEmptyRowCarbonTable"),
-      
Seq(Row("a",25),Row("b",22),Row("c",23),Row(null,null),Row(null,null),Row(null,null)))
+      Seq(Row("a", 25),

Review comment:
       changed for all places




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org