[GitHub] [carbondata] QiangCai commented on a change in pull request #3994: [CARBONDATA-4040] Fix data mismatch incase of compaction failure and retry success

[GitBox]

QiangCai commented on a change in pull request #3994:
URL: https://github.com/apache/carbondata/pull/3994#discussion_r510548190



##########
File path: 
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
##########
@@ -398,27 +398,29 @@ public static void 
mergeIndexAndWriteSegmentFile(CarbonTable carbonTable, String
    * @throws IOException
    */
   public static String writeSegmentFile(CarbonTable carbonTable, String 
segmentId, String UUID,

Review comment:
       for the update, it will have more than one timestamp, right

##########
File path: 
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
##########
@@ -398,27 +398,29 @@ public static void 
mergeIndexAndWriteSegmentFile(CarbonTable carbonTable, String
    * @throws IOException
    */
   public static String writeSegmentFile(CarbonTable carbonTable, String 
segmentId, String UUID,

Review comment:
       for the update, it will have more than one timestamp, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org