QiangCai commented on a change in pull request #3935:
URL: https://github.com/apache/carbondata/pull/3935#discussion_r510566102



##########
File path: 
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
##########
@@ -323,10 +320,6 @@ public static boolean 
recordNewLoadMetadata(LoadMetadataDetails newMetaEntry,
             for (LoadMetadataDetails entry : listOfLoadFolderDetails) {

Review comment:
       Let's discuss insertOverwrite behavior.
   Should we delete old data immediately?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to