[GitHub] [carbondata] jack86596 commented on a change in pull request #4019: [CARBONDATA-4053] Fix alter table rename column failed when column name is "a"

[GitBox]

jack86596 commented on a change in pull request #4019:
URL: https://github.com/apache/carbondata/pull/4019#discussion_r529342790



##########
File path: 
integration/spark/src/main/scala/org/apache/spark/util/AlterTableUtil.scala
##########
@@ -332,12 +332,26 @@ object AlterTableUtil {
       tableProperties: mutable.Map[String, String],
       oldColumnName: String,
       newColumnName: String): Unit = {
+    val columnProperties = Seq("NO_INVERTED_INDEX",
+      "INVERTED_INDEX",
+      "INDEX_COLUMNS",
+      "COLUMN_META_CACHE",
+      "DICTIONARY_INCLUDE",

Review comment:
       Removed "DICTIONARY_INCLUDE" and "DICTIONARY_EXCLUDE". All properties 
which related to column name are now included in the list. 
   "INDEX_COLUMNS" and "SPATIAL_INDEX" is the property only for bloom index and 
spatial index table, which these two kinds of table are blocked to rename the 
column, so it is ok for these two properties not to be included in the property 
list.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org