vikramahuja1001 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r530969904
########## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ########## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.carbondata.core.util; + +import java.io.IOException; +import java.util.*; + +import org.apache.carbondata.common.logging.LogServiceFactory; +import org.apache.carbondata.core.constants.CarbonCommonConstants; +import org.apache.carbondata.core.datastore.filesystem.CarbonFile; +import org.apache.carbondata.core.datastore.impl.FileFactory; +import org.apache.carbondata.core.metadata.SegmentFileStore; +import org.apache.carbondata.core.metadata.schema.table.CarbonTable; +import org.apache.carbondata.core.statusmanager.LoadMetadataDetails; +import org.apache.carbondata.core.statusmanager.SegmentStatus; +import org.apache.carbondata.core.statusmanager.SegmentStatusManager; +import org.apache.carbondata.core.util.path.CarbonTablePath; + +import org.apache.hadoop.fs.Path; +import org.apache.log4j.Logger; + +/** + * Mantains the clean files command in carbondata. This class has methods for clean files + * operation. + */ +public class CleanFilesUtil { + + private static final Logger LOGGER = + LogServiceFactory.getLogService(CleanFilesUtil.class.getName()); + + /** + * This method will clean all the stale segments for table given table. In this method, we first + * get the stale segments(segments whose entry is not in the table status, but are present in + * the metadata folder) or in case when table status is deleted. To identify the stale segments + * we compare the segment files in the metadata folder with table status file, if it exists. The + * identified stale segments are then copied to the trash folder and then their .segment files + * are also deleted from the metadata folder. We only compare with tablestatus file here, not + * with tablestatus history file. + */ + public static void cleanStaleSegments(CarbonTable carbonTable) + throws IOException { + String metaDataLocation = carbonTable.getMetadataPath(); + long timeStampForTrashFolder = System.currentTimeMillis(); + String segmentFilesLocation = + CarbonTablePath.getSegmentFilesLocation(carbonTable.getTablePath()); + CarbonFile[] segmentFilesList = FileFactory.getCarbonFile(segmentFilesLocation).listFiles(); + // there are no segments present in the Metadata folder. Can return here + if (segmentFilesList.length == 0) { + return; + } + LoadMetadataDetails[] details = SegmentStatusManager.readLoadMetadata(metaDataLocation); + List<String> staleSegments = getStaleSegments(details, segmentFilesList); Review comment: Changed. separated flow for normal table and partition table. In case of normal table, getting the segment path from the .segment file location map and moving complete segment. In case of partition table flow, moving it file by file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
