ajantha-bhat commented on a change in pull request #4020:
URL: https://github.com/apache/carbondata/pull/4020#discussion_r531367494
##########
File path:
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonDataMergerUtil.java
##########
@@ -311,10 +311,8 @@ public static String getLoadNumberFromLoadName(String
loadName) {
listOfSegmentsToBeMerged =
identifySegmentsToBeMergedBasedOnSize(compactionSize,
listOfSegmentsLoadedInSameDateInterval, carbonLoadModel);
} else {
-
- listOfSegmentsToBeMerged =
-
identifySegmentsToBeMergedBasedOnSegCount(listOfSegmentsLoadedInSameDateInterval,
- tableLevelProperties);
+ listOfSegmentsToBeMerged =
identifySegmentsToBeMergedBasedOnSegCount(compactionSize,
Review comment:
may be you can calculate compaction size, inside this method as table
property is already there. No need to modify this method signature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
