vikramahuja1001 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r532539140
########## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ########## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.carbondata.core.util; + +import java.io.IOException; +import java.util.*; + +import org.apache.carbondata.common.logging.LogServiceFactory; +import org.apache.carbondata.core.constants.CarbonCommonConstants; +import org.apache.carbondata.core.datastore.filesystem.CarbonFile; +import org.apache.carbondata.core.datastore.impl.FileFactory; +import org.apache.carbondata.core.metadata.SegmentFileStore; +import org.apache.carbondata.core.metadata.schema.table.CarbonTable; +import org.apache.carbondata.core.mutate.CarbonUpdateUtil; +import org.apache.carbondata.core.statusmanager.LoadMetadataDetails; +import org.apache.carbondata.core.statusmanager.SegmentStatus; +import org.apache.carbondata.core.statusmanager.SegmentStatusManager; +import org.apache.carbondata.core.util.path.CarbonTablePath; + +import org.apache.hadoop.fs.Path; +import org.apache.log4j.Logger; + +/** + * Mantains the clean files command in carbondata. This class has methods for clean files + * operation. + */ +public class CleanFilesUtil { + + private static final Logger LOGGER = + LogServiceFactory.getLogService(CleanFilesUtil.class.getName()); + + /** + * This method will clean all the stale segments for a table, delete the source folder after + * copying the data to the trash and also remove the .segment files of the stale segments + */ + public static void cleanStaleSegments(CarbonTable carbonTable) + throws IOException { + long timeStampForTrashFolder = CarbonUpdateUtil.readCurrentTime(); + List<String> staleSegments = getStaleSegments(carbonTable); + if (staleSegments.size() > 0) { + for (String staleSegment : staleSegments) { + String segmentNumber = staleSegment.split(CarbonCommonConstants.UNDERSCORE)[0]; + SegmentFileStore fileStore = new SegmentFileStore(carbonTable.getTablePath(), + staleSegment); + Map<String, SegmentFileStore.FolderDetails> locationMap = fileStore.getSegmentFile() + .getLocationMap(); + if (locationMap != null) { + CarbonFile segmentLocation = FileFactory.getCarbonFile(carbonTable.getTablePath() + + CarbonCommonConstants.FILE_SEPARATOR + fileStore.getSegmentFile().getLocationMap() + .entrySet().iterator().next().getKey()); + // copy the complete segment to the trash folder + TrashUtil.copySegmentToTrash(segmentLocation, CarbonTablePath.getTrashFolderPath( + carbonTable.getTablePath()) + CarbonCommonConstants.FILE_SEPARATOR + + timeStampForTrashFolder + CarbonCommonConstants.FILE_SEPARATOR + CarbonTablePath + .SEGMENT_PREFIX + segmentNumber); + // Deleting the stale Segment folders. + try { + CarbonUtil.deleteFoldersAndFiles(segmentLocation); + } catch (IOException | InterruptedException e) { + LOGGER.error("Unable to delete the segment: " + segmentNumber + " from after moving" + + " it to the trash folder. Please delete them manually : " + e.getMessage(), e); + } + // delete the segment file as well + FileFactory.deleteFile(CarbonTablePath.getSegmentFilePath(carbonTable.getTablePath(), + staleSegment)); + } + } + staleSegments.clear(); + } + } + + /** + * This method will clean all the stale segments for partition table, delete the source folders + * after copying the data to the trash and also remove the .segment files of the stale segments + */ + public static void cleanStaleSegmentsForPartitionTable(CarbonTable carbonTable) + throws IOException { + long timeStampForTrashFolder = CarbonUpdateUtil.readCurrentTime(); + List<String> staleSegments = getStaleSegments(carbonTable); + if (staleSegments.size() > 0) { + for (String staleSegment : staleSegments) { + String segmentNumber = staleSegment.split(CarbonCommonConstants.UNDERSCORE)[0]; + // for each segment we get the indexfile first, then we get the carbondata file. Move both + // of those to trash folder + List<CarbonFile> filesToDelete = new ArrayList<>(); + SegmentFileStore fileStore = new SegmentFileStore(carbonTable.getTablePath(), + staleSegment); + List<String> indexOrMergeFiles = fileStore.readIndexFiles(SegmentStatus.SUCCESS, true, + FileFactory.getConfiguration()); + for (String indexfile : indexOrMergeFiles) { + // copy the index or merge file to the trash folder + TrashUtil.copyFileToTrashFolder(indexfile, CarbonTablePath.getTrashFolderPath(carbonTable + .getTablePath()) + CarbonCommonConstants.FILE_SEPARATOR + timeStampForTrashFolder + + CarbonCommonConstants.FILE_SEPARATOR + CarbonTablePath.SEGMENT_PREFIX + + segmentNumber); + filesToDelete.add(FileFactory.getCarbonFile(indexfile)); + } + // get carbondata files from here + Map<String, List<String>> indexFilesMap = fileStore.getIndexFilesMap(); + for (Map.Entry<String, List<String>> entry : indexFilesMap.entrySet()) { + for (String file : entry.getValue()) { + // copy the carbondata file to trash + TrashUtil.copyFileToTrashFolder(file, CarbonTablePath.getTrashFolderPath(carbonTable + .getTablePath()) + CarbonCommonConstants.FILE_SEPARATOR + timeStampForTrashFolder + + CarbonCommonConstants.FILE_SEPARATOR + CarbonTablePath.SEGMENT_PREFIX + + segmentNumber); + filesToDelete.add(FileFactory.getCarbonFile(file)); + } + } + // After every file of that segment has been copied, need to delete those files. + LOGGER.info("Segment number: " + segmentNumber + "has been successfully copied to the" + + " trash folder"); + try { + for (CarbonFile file : filesToDelete) { + FileFactory.deleteFile(file.getAbsolutePath()); + // deleting empty partition folders of partition table + SegmentFileStore.deleteEmptyPartitionFolders(FileFactory.getCarbonFile(new Path(file + .getAbsolutePath()).getParent().toString())); + } + filesToDelete.clear(); + } catch (IOException e) { + LOGGER.error("Error while deleting the source data files. Please delete the files of" + + " segment: " + segmentNumber + " manually.", e); + } + // Delete the segment file too + FileFactory.deleteFile(CarbonTablePath.getSegmentFilePath(carbonTable.getTablePath(), + staleSegment)); + } + staleSegments.clear(); + } + } + + /** + * This method will find all the stale segments by comparing the segment files in the + * metadata directory with the segments in the table status file. Any segment which has entry + * in the metadata folder and is not present in the table status file is considered as a + * stale segment. Only comparing from tablestatus file, not checking tablestatus.history file + */ + private static List<String> getStaleSegments(CarbonTable carbonTable) { + // details contains segments in the tablestatus file, and all segments contains segments files. + // Segment number from those segment files is extracted and Stale segement file name is + // returned. + String metaDataLocation = carbonTable.getMetadataPath(); + String segmentFilesLocation = + CarbonTablePath.getSegmentFilesLocation(carbonTable.getTablePath()); + CarbonFile[] segmentFilesList = FileFactory.getCarbonFile(segmentFilesLocation).listFiles(); + ArrayList<String> staleSegmentList = new ArrayList<>(segmentFilesList.length); + // there are no segments present in the Metadata folder. Can return here + if (segmentFilesList.length == 0) { + return staleSegmentList; + } + LoadMetadataDetails[] details = SegmentStatusManager.readLoadMetadata(metaDataLocation); + Set<String> loadNameSet = new HashSet<>(details.length); + Arrays.stream(details).map(loadMetadataDetails -> loadMetadataDetails.getLoadName()) + .forEach(loadName -> loadNameSet.add(loadName)); + for (CarbonFile segmentFile : segmentFilesList) { + if (!loadNameSet.contains(segmentFile.getName().split(CarbonCommonConstants + .UNDERSCORE)[0])) { + staleSegmentList.add(segmentFile.getName()); Review comment: taking the segment with the latest timestamp. For that, sorting the list of segment files and taking the one with the latest timestamp in case of same timestamp. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
