VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532710929
########## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonRangeListExpression.java ########## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.carbondata.geo.scan.expression; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Comparator; +import java.util.List; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +import org.apache.carbondata.common.annotations.InterfaceAudience; +import org.apache.carbondata.core.datastore.block.SegmentProperties; +import org.apache.carbondata.core.metadata.datatype.DataTypes; +import org.apache.carbondata.core.scan.expression.ColumnExpression; +import org.apache.carbondata.core.scan.expression.Expression; +import org.apache.carbondata.core.scan.expression.ExpressionResult; +import org.apache.carbondata.core.scan.expression.UnknownExpression; +import org.apache.carbondata.core.scan.expression.conditional.ConditionalExpression; +import org.apache.carbondata.core.scan.filter.executer.FilterExecutor; +import org.apache.carbondata.core.scan.filter.intf.ExpressionType; +import org.apache.carbondata.core.scan.filter.intf.RowIntf; +import org.apache.carbondata.core.scan.filter.resolver.FilterResolverIntf; +import org.apache.carbondata.core.scan.filter.resolver.RowLevelFilterResolverImpl; +import org.apache.carbondata.geo.GeoConstants; +import org.apache.carbondata.geo.GeoHashUtils; +import org.apache.carbondata.geo.scan.filter.executor.PolygonFilterExecutorImpl; + +/** + * InPolygonRangeList expression processor. It inputs the InPolygonRangeList string to + * the Geo implementation's query method, inputs lists of range of IDs and is to be calculated + * the and/or/diff range list to filter. And then, build InExpression with list of all the IDs + * present in those list of ranges. + */ +@InterfaceAudience.Internal +public class PolygonRangeListExpression extends UnknownExpression + implements ConditionalExpression { + + private String polygonRangeList; + + private String opType; + + private List<Long[]> ranges = new ArrayList<Long[]>(); + + private ColumnExpression column; + + private static final ExpressionResult trueExpRes = + new ExpressionResult(DataTypes.BOOLEAN, true); + + private static final ExpressionResult falseExpRes = + new ExpressionResult(DataTypes.BOOLEAN, false); + + public PolygonRangeListExpression(String polygonRangeList, String opType, String columnName) { + this.polygonRangeList = polygonRangeList; + this.opType = opType; + this.column = new ColumnExpression(columnName, DataTypes.LONG); + } + + private void processExpression() { + try { + // 1. parse the range list string + List<String> rangeLists = new ArrayList<>(); + Pattern pattern = Pattern.compile(GeoConstants.RANGELIST_REG_EXPRESSION); + Matcher matcher = pattern.matcher(polygonRangeList); + while (matcher.find()) { + String matchedStr = matcher.group(); + rangeLists.add(matchedStr); + } + // 2. process the range lists + if (rangeLists.size() > 0) { + List<Long[]> processedRangeList = getRangeListFromString(rangeLists.get(0)); + for (int i = 1; i < rangeLists.size(); i++) { + List<Long[]> tempRangeList = getRangeListFromString(rangeLists.get(i)); + processedRangeList = GeoHashUtils.processRangeList( + processedRangeList, tempRangeList, opType); + } + ranges = processedRangeList; + GeoHashUtils.validateRangeList(ranges); + } + } catch (Exception e) { + throw new RuntimeException(e); + } + } + + private void sortRange(List<Long[]> rangeList) { + rangeList.sort(new Comparator<Long[]>() { + @Override + public int compare(Long[] x, Long[] y) { + return Long.compare(x[0], y[0]); + } + }); + } + + private void combineRange(List<Long[]> rangeList) { + if (rangeList.size() > 1) { + for (int i = 0, j = i + 1; i < rangeList.size() - 1; i++, j++) { + long previousEnd = rangeList.get(i)[1]; + long nextStart = rangeList.get(j)[0]; + if (previousEnd + 1 == nextStart) { Review comment: Not handled for overlapping ranges ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
