ajantha-bhat commented on a change in pull request #4055:
URL: https://github.com/apache/carbondata/pull/4055#discussion_r544852773
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java
##########
@@ -84,6 +84,9 @@ public void fillVector(int[] invertedIndex, int[]
invertedIndexReverse, byte[] d
vector = ColumnarVectorWrapperDirectFactory
.getDirectVectorWrapperFactory(vectorInfo, vector, invertedIndex,
nullBitset,
vectorInfo.deletedRows, false, false);
+ if (dictionaryVector.getIntsSize() < rowsNum) {
Review comment:
add a comment about when dictionaryVector.getIntsSize() < rowsNum, I
think it is only during array of string / varchar with local dictionary .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
