[GitHub] [carbondata] nihal0107 commented on a change in pull request #4068: [CARBONDATA-3987] Handled filter and IUD operation for pagination reader in SDK

[GitBox]

nihal0107 commented on a change in pull request #4068:
URL: https://github.com/apache/carbondata/pull/4068#discussion_r551136803



##########
File path: 
sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/PaginationCarbonReader.java
##########
@@ -174,14 +170,15 @@ private Range getBlockletIndexRange(long fromRowNumber, 
long toRowNumber) {
         BlockletDetailInfo detailInfo =
             ((CarbonInputSplit) allBlockletSplits.get(i)).getDetailInfo();
         int rowCountInBlocklet = detailInfo.getRowCount();
-        Object[] rowsInBlocklet = new Object[rowCountInBlocklet];
+        // Object[] rowsInBlocklet = new Object[rowCountInBlocklet];
+        List<Object> rowsInBlocklet = new ArrayList<>();

Review comment:
       Using array is causing the problem in case of update or delete operation.
   Removed unused code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org