VenuReddy2103 commented on a change in pull request #4071:
URL: https://github.com/apache/carbondata/pull/4071#discussion_r566795460
##########
File path:
index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/DropTableTest.scala
##########
@@ -88,4 +90,16 @@ class DropTableTest extends QueryTest with BeforeAndAfterAll
{
assert(sql("show indexes on testDrop").collect().isEmpty)
sql("drop table if exists testDrop")
}
+
+ test("test index drop when SI table is not deleted while main table is
deleted") {
+ sql("drop table if exists testDrop")
+ sql("create table testDrop (a string, b string, c string) STORED AS
carbondata")
+ sql("create index index11 on table testDrop (c) AS 'carbondata'")
+ sql("insert into testDrop values('ab', 'cd', 'ef')")
+ val mock = TestSecondaryIndexUtils.mockSIDrop()
Review comment:
I think, we should either run this testcase in a non-default db or drop
index like any other normal table i.e., add `sql("drop table if exists
index11")` before create index(line 97). Because, we have mocked to fail SI
deletion. SI table remains in default db thereafter. Hence, if we try to run
this testcase multiple times, it fails to create index with `index11` name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
