Indhumathi27 commented on a change in pull request #4083:
URL: https://github.com/apache/carbondata/pull/4083#discussion_r567602928
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/rdd/SecondaryIndexCreator.scala
##########
@@ -580,34 +581,39 @@ object SecondaryIndexCreator {
sparkSession: SparkSession,
carbonTable: CarbonTable,
projections: String,
- segments: Array[String]): DataFrame = {
+ segments: Array[String],
+ isPositionReferenceRequired: Boolean = false): DataFrame = {
try {
CarbonThreadUtil.threadSet(
CarbonCommonConstants.CARBON_INPUT_SEGMENTS +
carbonTable.getDatabaseName +
CarbonCommonConstants.POINT + carbonTable.getTableName,
segments.mkString(","))
val logicalPlan = sparkSession.sql(
s"select $projections from ${ carbonTable.getDatabaseName }.${
carbonTable.getTableName}").queryExecution.logical
- val positionId =
UnresolvedAlias(Alias(UnresolvedFunction("getPositionId",
Review comment:
i think, instead you can check if isPositionReferenceRequired is false
and return SparkSQLUtil.execute(newLogicalPlan, sparkSession) and keep old
changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
