akashrn5 commented on a change in pull request #4080:
URL: https://github.com/apache/carbondata/pull/4080#discussion_r569266756
##########
File path:
index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestSIWithAddSegment.scala
##########
@@ -86,8 +86,8 @@ class TestSIWithAddSegment extends QueryTest with
BeforeAndAfterAll {
sql(s"alter table maintable1 add segment options('path'='${ newSegmentPath
}', " +
s"'format'='carbon')")
sql("CREATE INDEX maintable1_si on table maintable1 (c) as 'carbondata'")
- assert(sql("show segments for table maintable1_si").collect().length ==
- sql("show segments for table maintable1").collect().length)
+ assert(sql("show segments for table maintable1_si").collect().length == 2)
+ assert(sql("show segments for table maintable1").collect().length == 3)
Review comment:
since for external added segments we don't load SI, its scenario of
segment mismatch of SI and main table, it may lead to wrong results or failure.
We don't yet support of getting the results from SI for some segments and some
segments from main table right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
