ajantha-bhat commented on a change in pull request #4072:
URL: https://github.com/apache/carbondata/pull/4072#discussion_r577387770
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
##########
@@ -297,6 +297,10 @@ public static boolean deleteFile(String filePath) throws
IOException {
return getCarbonFile(filePath).deleteFile();
}
+ public static boolean deleteFile(CarbonFile carbonFile) throws IOException {
Review comment:
Please remove `deleteFile(CarbonFile carbonFile)`, because there is no
extra function is happening here. directly call carbonFile.deleteFile() in the
usages.
If there was some extra functionality, then it makes sense to have to APIfor
carbonFile also to avoid getting CarbonFile again. for this case it is not
needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
