MarvinLitt commented on a change in pull request #4097:
URL: https://github.com/apache/carbondata/pull/4097#discussion_r587998973



##########
File path: 
integration/spark/src/main/scala/org/apache/carbondata/index/TextMatchUDF.scala
##########
@@ -34,13 +32,3 @@ class TextMatchMaxDocUDF extends ((String, Int) => Boolean) 
with Serializable {
     v1.length > 0
   }
 }

Review comment:
       the same as the Spatial index, if removed, how to use the fun.

##########
File path: 
integration/spark/src/main/scala/org/apache/carbondata/geo/InPolygonUDF.scala
##########
@@ -59,23 +58,3 @@ class InPolygonRangeListUDF extends ((String, String) => 
Boolean) with Serializa
     true // Carbon applies the filter. So, Spark do not have to apply filter.
   }
 }

Review comment:
       this filter is use for Spatial index´╝î if remove how about that?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to