vikramahuja1001 commented on a change in pull request #4099:
URL: https://github.com/apache/carbondata/pull/4099#discussion_r590253814
##########
File path: core/src/main/java/org/apache/carbondata/core/index/IndexUtil.java
##########
@@ -112,15 +115,32 @@ public static IndexJob getIndexJob(Configuration
configuration) throws IOExcepti
*/
private static void executeClearIndexJob(IndexJob indexJob,
CarbonTable carbonTable, String indexToClear) throws IOException {
- SegmentStatusManager.ValidAndInvalidSegmentsInfo
validAndInvalidSegmentsInfo =
- getValidAndInvalidSegments(carbonTable,
FileFactory.getConfiguration());
- List<String> invalidSegment = new ArrayList<>();
- for (Segment segment : validAndInvalidSegmentsInfo.getInvalidSegments()) {
- invalidSegment.add(segment.getSegmentNo());
+ IndexInputFormat indexInputFormat;
+ if (!carbonTable.isTransactionalTable()) {
+ ReadCommittedScope readCommittedScope =
+ new LatestFilesReadCommittedScope(carbonTable.getTablePath(),
+ FileFactory.getConfiguration());
+ LoadMetadataDetails[] loadMetadataDetails =
readCommittedScope.getSegmentList();
+ List<Segment> listOfValidSegments = new ArrayList<>();
+ for (LoadMetadataDetails segment : loadMetadataDetails) {
+ Segment seg = new Segment(segment.getLoadName(),
segment.getSegmentFile());
+ seg.setLoadMetadataDetails(segment);
+ listOfValidSegments.add(seg);
+ }
+ indexInputFormat =
+ new IndexInputFormat(carbonTable, listOfValidSegments, new
ArrayList<>(0), true,
+ indexToClear);
+ } else {
+ SegmentStatusManager.ValidAndInvalidSegmentsInfo
validAndInvalidSegmentsInfo =
+ getValidAndInvalidSegments(carbonTable,
FileFactory.getConfiguration());
+ List<String> invalidSegment = new ArrayList<>();
+ for (Segment segment : validAndInvalidSegmentsInfo.getInvalidSegments())
{
Review comment:
Use Java stream here instead of a for loop
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
