akashrn5 commented on a change in pull request #4104:
URL: https://github.com/apache/carbondata/pull/4104#discussion_r597487929



##########
File path: 
processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
##########
@@ -190,7 +200,7 @@ public boolean execute(List<RawResultIterator> 
unsortedResultIteratorList,
       LOGGER.error(e.getLocalizedMessage(), e);
       throw e;
     } finally {
-      if (partitionSpec != null) {

Review comment:
       yes, @liuhe0702 instead of making parameter changes or adding 
constructors, check property here only and can avoid changes in MergerRDD




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to