[ 
https://issues.apache.org/jira/browse/CARBONDATA-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15499119#comment-15499119
 ] 

ASF GitHub Bot commented on CARBONDATA-245:
-------------------------------------------

Github user ravikiran23 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/160#discussion_r79284253
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/writer/CarbonDictionaryWriterImpl.java
 ---
    @@ -199,7 +199,10 @@ public CarbonDictionaryWriterImpl(String hdfsStorePath,
        */
       @Override public void close() throws IOException {
         if (null != dictionaryThriftWriter) {
    -      writeDictionaryFile();
    +      // if stream is open then only need to write dictionary file.
    +      if(dictionaryThriftWriter.isOpen()){
    --- End diff --
    
    fixed


> Actual Exception is getting lost in case of data dictionary file generation.
> ----------------------------------------------------------------------------
>
>                 Key: CARBONDATA-245
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-245
>             Project: CarbonData
>          Issue Type: Bug
>          Components: data-load
>            Reporter: ravikiran
>            Priority: Minor
>
> Actual Exception is getting lost in case of data dictionary file 
> generation.getting the null pointer exception as in the finally block we are 
> trying to write data to a null stream.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to