[ 
https://issues.apache.org/jira/browse/CARBONDATA-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506079#comment-15506079
 ] 

ASF GitHub Bot commented on CARBONDATA-208:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/176#discussion_r79554930
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/util/CarbonTimeStatisticsFactory.java
 ---
    @@ -52,12 +56,27 @@ public static LoadStatistics 
getLoadStatisticsInstance() {
         return LoadStatisticsInstance;
       }
     
    -  private static DriverQueryStatisticsRecorder 
genQueryStatisticsRecorderInstance() {
    -    return DriverQueryStatisticsRecorder.getInstance();
    +  private static QueryStatisticsRecorder 
genQueryStatisticsRecorderInstance() {
    +    if (queryStatisticsRecorderInstanceType.equalsIgnoreCase("true")) {
    +      return DriverQueryStatisticsRecorderImpl.getInstance();
    +    } else {
    +      return DriverQueryStatisticsRecorderDummy.getInstance();
    +    }
       }
     
    -  public static DriverQueryStatisticsRecorder 
getQueryStatisticsRecorderInstance() {
    +  public static QueryStatisticsRecorder 
getQueryStatisticsRecorderInstance() {
         return QueryStatisticsRecorderInstance;
       }
     
    +  public static QueryStatisticsRecorder getQueryStatisticsRecorder(String 
queryId) {
    --- End diff --
    
    I think rename it to createRecorder is better than 'get'


> User should be able to turn on and off the STATISTIC log
> --------------------------------------------------------
>
>                 Key: CARBONDATA-208
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-208
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Jacky Li
>            Priority: Minor
>             Fix For: 0.2.0-incubating
>
>
> Currently there are many STATISTIC log for performance tuning purpose, but it 
> should be configurable by the user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to