[ 
https://issues.apache.org/jira/browse/CARBONDATA-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515355#comment-15515355
 ] 

ASF GitHub Bot commented on CARBONDATA-208:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/176#discussion_r80179589
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/util/CarbonTimeStatisticsFactory.java
 ---
    @@ -17,13 +17,14 @@
     
     package org.apache.carbondata.core.util;
     
    -import 
org.apache.carbondata.core.carbon.querystatistics.DriverQueryStatisticsRecorder;
    +import org.apache.carbondata.core.carbon.querystatistics.*;
     import org.apache.carbondata.core.constants.CarbonCommonConstants;
     
     public class CarbonTimeStatisticsFactory {
       private static String LoadStatisticsInstanceType;
       private static LoadStatistics LoadStatisticsInstance;
    -  private static DriverQueryStatisticsRecorder 
QueryStatisticsRecorderInstance;
    +  private static String queryStatisticsRecorderInstanceType;
    +  private static QueryStatisticsRecorder QueryStatisticsRecorderInstance;
    --- End diff --
    
    And seems it is not initialized but returned in 
`getQueryStatisticsRecorderInstance` function?


> User should be able to turn on and off the STATISTIC log
> --------------------------------------------------------
>
>                 Key: CARBONDATA-208
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-208
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Jacky Li
>            Priority: Minor
>             Fix For: 0.2.0-incubating
>
>
> Currently there are many STATISTIC log for performance tuning purpose, but it 
> should be configurable by the user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to