[ 
https://issues.apache.org/jira/browse/CARBONDATA-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568196#comment-15568196
 ] 

ASF GitHub Bot commented on CARBONDATA-276:
-------------------------------------------

Github user sujith71955 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/200#discussion_r82968804
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/UnivocityCsvParser.java
 ---
    @@ -102,8 +102,8 @@ public void initialize() throws IOException {
         parserSettings.setMaxColumns(
             getMaxColumnsForParsing(csvParserVo.getNumberOfColumns(), 
csvParserVo.getMaxColumns()));
         parserSettings.setNullValue("");
    -    parserSettings.setIgnoreLeadingWhitespaces(false);
    -    parserSettings.setIgnoreTrailingWhitespaces(false);
    +    parserSettings.setIgnoreLeadingWhitespaces(csvParserVo.getTrim());
    --- End diff --
    
    Also one more point it will be better to set this property in column level 
while creating the table itself as its column properties , this will avoid user 
to provide this option every time while data loading


> Add trim option
> ---------------
>
>                 Key: CARBONDATA-276
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-276
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Lionx
>            Assignee: Lionx
>            Priority: Minor
>
> Fix a bug and add trim option.
> Bug: When string is contains LeadingWhiteSpace or TrailingWhiteSpace, query 
> result is null. This is because the dictionary ignore the LeadingWhiteSpace 
> and TrailingWhiteSpace and the csvInput dose not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to