[ 
https://issues.apache.org/jira/browse/CARBONDATA-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568980#comment-15568980
 ] 

ASF GitHub Bot commented on CARBONDATA-283:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/207#discussion_r83026458
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/util/CarbonTableStatusUtil.java
 ---
    @@ -0,0 +1,92 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.carbondata.processing.util;
    +
    +import java.text.SimpleDateFormat;
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.Date;
    +import java.util.List;
    +
    +import org.apache.carbondata.common.logging.LogService;
    +import org.apache.carbondata.common.logging.LogServiceFactory;
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +import org.apache.carbondata.core.load.LoadMetadataDetails;
    +
    +/**
    + * This class contains all table status file utilities
    + */
    +public final class CarbonTableStatusUtil {
    +  private static final LogService LOGGER =
    +      
LogServiceFactory.getLogService(CarbonTableStatusUtil.class.getName());
    +
    +  private CarbonTableStatusUtil() {
    +
    +  }
    +
    +  /**
    +   * updates table status details using latest metadata
    +   *
    +   * @param oldMetadata
    +   * @param newMetadata
    +   * @return
    +   */
    +
    +  public static List<LoadMetadataDetails> updateLatestTableStatusDetails(
    --- End diff --
    
    I think these should not be utility functions, but should be member 
function of LoadMetadataDetails


> Improve the test cases for concurrent scenarios
> -----------------------------------------------
>
>                 Key: CARBONDATA-283
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-283
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Manohar Vanam
>            Assignee: Manohar Vanam
>            Priority: Minor
>
> Improve test cases for data retention concurrent scenarios



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to