[
https://issues.apache.org/jira/browse/CARBONDATA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574306#comment-15574306
]
ASF GitHub Bot commented on CARBONDATA-299:
-------------------------------------------
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/236#discussion_r83360819
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/dictionary/InMemBiDictionary.java
---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.carbondata.processing.newflow.dictionary;
+
+import java.util.Map;
+
+import org.apache.carbondata.core.devapi.DictionaryGenerator;
+import org.apache.carbondata.core.devapi.GeneratingBiDictionary;
+
+import com.google.common.collect.BiMap;
+import com.google.common.collect.HashBiMap;
+
+public class InMemBiDictionary<K, V> extends GeneratingBiDictionary<K, V> {
--- End diff --
This `InMemBiDictionary` is for one column, when it comes to cache, I think
the cached object is 'BiDictionary`. Since the cache provides KV API, so we
need a TableDictionary to make use of the cache. I am thinking to add another
class for table dictionary, like
```
CachedTableDictionary tableDict = new CachedTableDictionary(tableName)
key = tableDict.getOrGenerateKey(columnName, value)
```
Inside `CachedTableDictionary`, it will maintain a cache of
`HashMap<columnName, BiDictionary>`
I am thinking to use
[Cache](https://github.com/google/guava/wiki/CachesExplained) from Guava also
> 4. Add dictionary generator interfaces and give implementation for pre
> created dictionary.
> ------------------------------------------------------------------------------------------
>
> Key: CARBONDATA-299
> URL: https://issues.apache.org/jira/browse/CARBONDATA-299
> Project: CarbonData
> Issue Type: Sub-task
> Reporter: Ravindra Pesala
> Assignee: Jacky Li
> Fix For: 0.2.0-incubating
>
>
> Add dictionary generator interfaces and give implementation for pre-created
> dictionary(which is generated separetly).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
