[ https://issues.apache.org/jira/browse/CARBONDATA-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591240#comment-15591240 ]
ASF GitHub Bot commented on CARBONDATA-298: ------------------------------------------- Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/240#discussion_r84228406 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/parser/GenericParser.java --- @@ -0,0 +1,22 @@ +package org.apache.carbondata.processing.newflow.parser; + +/** + * Parse the data according to implementation, The implementation classes can be struct, array or + * map datatypes. + */ +public interface GenericParser<E> { + + /** + * Parse the data as per the delimiter + * @param data + * @return + */ + E parse(String data); + + /** + * Children of the parser. + * @param parser + */ + void addChildren(GenericParser parser); --- End diff -- This can be the behavior of parser for complex type only, so I think you can create a sub-interface for `ComplexTypePaser` extending `GenericParser`. Or even better, you can remove it and add it in `ArrayParserImpl` and `StructParserImpl` only > 3. Add InputProcessorStep which should iterate recordreader and parse the > data as per the data type. > ---------------------------------------------------------------------------------------------------- > > Key: CARBONDATA-298 > URL: https://issues.apache.org/jira/browse/CARBONDATA-298 > Project: CarbonData > Issue Type: Sub-task > Reporter: Ravindra Pesala > Fix For: 0.2.0-incubating > > > Add InputProcessorStep which should iterate recordreader/RecordBufferedWriter > and parse the data as per the data types. -- This message was sent by Atlassian JIRA (v6.3.4#6332)