[jira] [Commented] (CARBONDATA-298) 3. Add InputProcessorStep which should iterate recordreader and parse the data as per the data type.

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/CARBONDATA-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591241#comment-15591241
 ] 

ASF GitHub Bot commented on CARBONDATA-298:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/240#discussion_r84229327
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/newflow/complexobjects/StructObject.java
 ---
    @@ -0,0 +1,19 @@
    +package org.apache.carbondata.processing.newflow.complexobjects;
    +
    +public class StructObject {
    +
    +  private Object[] data;
    +
    +  public StructObject(Object[] data) {
    +    this.data = data;
    +  }
    +
    +  public Object[] getData() {
    +    return data;
    +  }
    +
    +  public void setData(Object[] data) {
    --- End diff --
    
    instead of just setting data, I think it is better to add function like 
`addMember(Object member)`, so that in `StructParserImpl` can make use of 
`addMember`


> 3. Add InputProcessorStep which should iterate recordreader and parse the 
> data as per the data type.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: CARBONDATA-298
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-298
>             Project: CarbonData
>          Issue Type: Sub-task
>            Reporter: Ravindra Pesala
>             Fix For: 0.2.0-incubating
>
>
> Add InputProcessorStep which should iterate recordreader/RecordBufferedWriter 
> and parse the data as per the data types.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)