[
https://issues.apache.org/jira/browse/CARBONDATA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593598#comment-15593598
]
ASF GitHub Bot commented on CARBONDATA-328:
-------------------------------------------
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/248#discussion_r84404806
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -49,7 +49,7 @@ object CommonUtil {
"Column group doesn't support Timestamp datatype:" + x)
}
// if invalid column is present
- else if (dims.filter { dim => dim.column.equalsIgnoreCase(x)
}.isEmpty) {
+ else if (!dims.exists { dim => dim.column.equalsIgnoreCase(x) }) {
--- End diff --
use `!dims.exists(_.column.equalsIgnoreCase(x))` instead of having `{`
modify all places
> Improve Code and Fix Warnings
> -----------------------------
>
> Key: CARBONDATA-328
> URL: https://issues.apache.org/jira/browse/CARBONDATA-328
> Project: CarbonData
> Issue Type: Improvement
> Reporter: Prabhat Kashyap
> Priority: Trivial
>
> Remove compiler warning and improve the existing code according to the
> standards.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
