[
https://issues.apache.org/jira/browse/CARBONDATA-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15597989#comment-15597989
]
ASF GitHub Bot commented on CARBONDATA-336:
-------------------------------------------
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/255#discussion_r84578556
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala ---
@@ -926,14 +926,14 @@ class CarbonSqlParser()
(INTO ~> TABLE ~> (ident <~ ".").? ~ ident) ~
(OPTIONS ~> "(" ~> repsep(loadOptions, ",") <~ ")").? <~ opt(";") ^^
{
case filePath ~ isOverwrite ~ table ~ partionDataOptions =>
- val (schema, tablename) = table match {
+ val (databaseNameOp, tableName) = table match {
--- End diff --
1. Why add "Op", because this is option[], so all places using the below :
case class LoadTable(
databaseNameOp: Option[String],
tableName: String,
2.Using options.dbName to get databaseName.
> Align the the name description
> ------------------------------
>
> Key: CARBONDATA-336
> URL: https://issues.apache.org/jira/browse/CARBONDATA-336
> Project: CarbonData
> Issue Type: Improvement
> Affects Versions: 0.2.0-incubating
> Reporter: Liang Chen
> Assignee: Liang Chen
> Priority: Minor
> Fix For: 0.2.0-incubating
>
>
> Align the the name description for databaseNameOp and tableName.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
