[
https://issues.apache.org/jira/browse/CARBONDATA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15607187#comment-15607187
]
ASF GitHub Bot commented on CARBONDATA-37:
------------------------------------------
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/219#discussion_r85040709
--- Diff:
processing/src/test/java/org/apache/carbondata/core/keygenerator/directdictionary/timestamp/TimeStampDirectDictionaryGeneratorTest.java
---
@@ -37,7 +37,7 @@
private int surrogateKey = -1;
@Before public void setUp() throws Exception {
- TimeStampDirectDictionaryGenerator generator =
TimeStampDirectDictionaryGenerator.instance;
+ TimeStampDirectDictionaryGenerator generator = new
TimeStampDirectDictionaryGenerator(CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT);
--- End diff --
Should use carbon property to create generator, not default value.
please correct all.
> Support Date/Time format for Timestamp columns to be defined at column level
> ----------------------------------------------------------------------------
>
> Key: CARBONDATA-37
> URL: https://issues.apache.org/jira/browse/CARBONDATA-37
> Project: CarbonData
> Issue Type: Improvement
> Reporter: Vimal Das Kammath
> Assignee: Lionx
>
> Carbon support defining the Date/Time format. But the configuration for the
> same is present in carbon.properties and hence is global for all tables.
> This global configuration for timestamp format cannot support scenarios where
> different tables or different Timestamp columns in the same table.
> Suggest to provide option in the create table DDL itself to define the format
> for each Timestamp column. Also provide defaults so that users can create
> table with Timestamp columns without having to always define the Date/Time
> format.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
