[
https://issues.apache.org/jira/browse/CARBONDATA-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615658#comment-15615658
]
ASF GitHub Bot commented on CARBONDATA-343:
-------------------------------------------
GitHub user Hexiaoqiao opened a pull request:
https://github.com/apache/incubator-carbondata/pull/271
[CARBONDATA-343] delete some duplicated definition code
Delete some duplicated definition code in GlobalDictionaryUtil.scala which
is mentioned as
[CARBONDATA-343](https://issues.apache.org/jira/browse/CARBONDATA-343) (and
learn new [Contributing to
CarbonData](https://cwiki.apache.org/confluence/display/CARBONDATA/Contributing+to+CarbonData)
btw.)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Hexiaoqiao/incubator-carbondata carbon-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/271.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #271
----
commit af810f8964772ee95dc6525375cae13010521604
Author: hexiaoqiao <[email protected]>
Date: 2016-10-28T14:44:57Z
CARBONDATA-343 delete some duplicated definition code
commit 5c9775d0f51baafb04423330591c8d90df9ebdff
Author: hexiaoqiao <[email protected]>
Date: 2016-10-28T14:52:51Z
CARBONDATA-343 delete some duplicated definition code
----
> Optimize the duplicated definition code in GlobalDictionaryUtil.scala
> ----------------------------------------------------------------------
>
> Key: CARBONDATA-343
> URL: https://issues.apache.org/jira/browse/CARBONDATA-343
> Project: CarbonData
> Issue Type: Improvement
> Reporter: Liang Chen
> Assignee: He Xiaoqiao
> Priority: Trivial
>
> The two rows code have some duplicated definition:
> -----------------
> val table =
> carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable.getAbsoluteTableIdentifier.getCarbonTableIdentifier
> val carbonTable = carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
