Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/492#discussion_r94771626
--- Diff:
core/src/main/java/org/apache/carbondata/scan/scanner/impl/FilterScanner.java
---
@@ -114,16 +117,22 @@ private void fillScannedResult(BlocksChunkHolder
blocksChunkHolder)
throws FilterUnsupportedException {
scannedResult.reset();
- QueryStatistic totalBlockletStatistic =
queryStatisticsModel.getStatisticsTypeAndObjMap()
- .get(QueryStatisticsConstants.TOTAL_BLOCKLET_NUM);
-
totalBlockletStatistic.addCountStatistic(QueryStatisticsConstants.TOTAL_BLOCKLET_NUM,
- totalBlockletStatistic.getCount() + 1);
-
queryStatisticsModel.getRecorder().recordStatistics(totalBlockletStatistic);
+ scannedResult.setBlockletId(
+ blockExecutionInfo.getBlockId() +
CarbonCommonConstants.FILE_SEPARATOR + blocksChunkHolder
+ .getDataBlock().nodeNumber());
// apply min max
if (isMinMaxEnabled) {
- BitSet bitSet = this.filterExecuter
-
.isScanRequired(blocksChunkHolder.getDataBlock().getColumnsMaxValue(),
- blocksChunkHolder.getDataBlock().getColumnsMinValue());
+ BitSet bitSet = null;
+ // check for implicit include filter instance
+ if (filterExecuter instanceof ImplicitColumnFilterExecutor) {
--- End diff --
Can u please explain what is this?? as this requirement is for updating and
deletion of data, why filter scanner logic will changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
