Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/528#discussion_r96108486
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/CsvInput.java
 ---
    @@ -194,28 +196,25 @@ public boolean processRow(StepMetaInterface smi, 
StepDataInterface sdi) throws K
       }
     
       class RddScanCallable implements Callable<Void> {
    -    List<CarbonIterator<String[]>> iterList;
    -
    -    RddScanCallable() {
    -      this.iterList = new ArrayList<CarbonIterator<String[]>>(1000);
    -    }
    -
    -    public void addJavaRddIterator(CarbonIterator<String[]> iter) {
    -      this.iterList.add(iter);
    -    }
    -
    -    @Override
    -    public Void call() throws Exception {
    -      StandardLogService.setThreadName(("PROCESS_DataFrame_PARTITIONS"),
    -          Thread.currentThread().getName());
    +    @Override public Void call() throws Exception {
    +      StandardLogService
    +          .setThreadName(("PROCESS_DataFrame_PARTITIONS"), 
Thread.currentThread().getName());
           try {
             String[] values = null;
    -        for (CarbonIterator<String[]> iter: iterList) {
    -          iter.initialize();
    -          while (iter.hasNext()) {
    -            values = iter.next();
    -            synchronized (putRowLock) {
    -              putRow(data.outputRowMeta, values);
    +        boolean hasNext = true;
    +        CarbonIterator<String[]> iter;
    +        boolean isInitialized = false;
    +        while (hasNext) {
    +          iter = getRddIterator(isInitialized);
    --- End diff --
    
    can you provide some comment in the code to describe this while loop


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to