Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102358957
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClient.java
---
@@ -86,7 +78,11 @@ public DictionaryKey getDictionary(DictionaryKey key) {
* shutdown dictionary client
*/
public void shutDown() {
- clientBootstrap.releaseExternalResources();
- clientBootstrap.shutdown();
+ workerGroup.shutdownGracefully();
--- End diff --
How about do like following:
```
if (clientBootstrap != null) {
if (clientBootstrap.group() != null) {
clientBootstrap.group().shutdownGracefully();
}
clientBootstrap = null;
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
