Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/584#discussion_r102617041
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/DimensionColumnChunkReader.java
---
@@ -35,7 +36,7 @@
* @param blockIndexes blocks to be read
* @return dimension column chunks
*/
- DimensionColumnDataChunk[] readDimensionChunks(FileHolder fileReader,
int[][] blockIndexes)
+ DimensionRawColumnChunk[] readRawDimensionChunks(FileHolder fileReader,
int[][] blockIndexes)
--- End diff --
Is this the `blockIndexes` or `blockletIndexes`?
I think it is blocklet index in each block, right? can you add description
in function header
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
