Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/638#discussion_r105406369
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -419,6 +419,94 @@ public static int
getFirstIndexUsingBinarySearch(FixedLengthDimensionDataChunk d
return -(low + 1);
}
+ public static int[] getRangeIndexUsingBinarySearch(
--- End diff --
There is not much difference between `getFirstIndexUsingBinarySearch` and
this method, I remembered in your last PR you have done binary search even for
getting the ranges, what happened to it, did you get any functional or
performance issues?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
