Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/642#discussion_r105577915
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java
---
@@ -192,12 +192,23 @@ private void
compressDataMyOwnWay(ColumnWithShortIndex[] indexes) {
}
map.add(start);
map.add(counter);
- this.keyBlock = convertToKeyArray(list);
--- End diff --
This is a comment for `compressMyOwnWay` function, suggest to use
`indexes.length / 2` as the initial size to allocate the ArrayList, instead of
10, which is too small and will cause repeated arraylist expansion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
