Github user gvramana commented on a diff in the pull request:

    
https://github.com/apache/incubator-carbondata/pull/641#discussion_r105883959
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
 ---
    @@ -429,9 +396,10 @@ protected BlockExecutionInfo 
getBlockExecutionInfoForBlock(QueryModel queryModel
        * @param blockMetadataInfo block metadata info
        * @return key size
        */
    -  private int getKeySize(List<QueryDimension> queryDimension, 
SegmentProperties blockMetadataInfo) {
    -    List<Integer> fixedLengthDimensionOrdinal =
    -        new 
ArrayList<Integer>(CarbonCommonConstants.DEFAULT_COLLECTION_SIZE);
    +  private int getKeySize(List<QueryDimension> queryDimension,
    +      SegmentProperties blockMetadataInfo) {
    +    Set<Integer> fixedLengthDimensionOrdinal =
    --- End diff --
    
    Comment above to tell its purpose


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to