Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/620#discussion_r105909192
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ---
@@ -352,9 +352,9 @@ public String getCarbonDataDirectoryPath(String
partitionId, String segmentId) {
* @return gets data file name only with out path
*/
public String getCarbonDataFileName(Integer filePartNo, Integer taskNo,
int bucketNumber,
- String factUpdateTimeStamp) {
- return DATA_PART_PREFIX + filePartNo + "-" + taskNo + "-" +
bucketNumber + "-"
- + factUpdateTimeStamp + CARBON_DATA_EXT;
+ int taskExtension, String factUpdateTimeStamp) {
+ return DATA_PART_PREFIX + filePartNo + "-" + taskNo + "_" +
taskExtension + "-" + bucketNumber
--- End diff --
I added another comment at last:
> How about rename taskExtension to batchNo. It is the batch number of the
batch sort, right? And in the file name, give a prefix like part-0-batchNo1-xxx
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
