Github user gvramana commented on a diff in the pull request:

    
https://github.com/apache/incubator-carbondata/pull/641#discussion_r106090223
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/DataTypeConverterUtil.scala
 ---
    @@ -77,4 +77,40 @@ object DataTypeConverterUtil {
           case DataType.STRUCT => "struct"
         }
       }
    +
    +  /**
    +   * convert from wrapper to external data type
    +   *
    +   * @param dataType
    +   * @return
    +   */
    +  def convertToThriftDataType(dataType: String): 
org.apache.carbondata.format.DataType = {
    --- End diff --
    
    Similar conversion function already would have exist, please try to reuse


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to