Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/635#discussion_r106803325
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
@@ -320,6 +320,80 @@ public static Object getDataBasedOnDataType(String
data, DataType actualDataType
}
+ public static byte[] getBytesBasedOnDataTypeForNoDictionaryColumn(String
dimensionValue,
+ DataType actualDataType) throws Throwable {
+ if (DataType.STRING.equals(actualDataType)) {
--- End diff --
Can you move this to switch case. Is there any reason it can't be moved to
switch case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
