Github user jackylk commented on a diff in the pull request:

    
https://github.com/apache/incubator-carbondata/pull/765#discussion_r110531763
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala
 ---
    @@ -504,3 +500,66 @@ class NewRddIterator(rddIter: Iterator[Row],
       }
     
     }
    +
    +/**
    + * LazyRddIterator invoke rdd.iterator method when invoking hasNext method.
    + * @param serializer
    + * @param serializeBytes
    + * @param partition
    + * @param carbonLoadModel
    + * @param context
    + */
    +class LazyRddIterator(serializer: SerializerInstance,
    +    serializeBytes: Array[Byte],
    +    partition: Partition,
    +    carbonLoadModel: CarbonLoadModel,
    +    context: TaskContext) extends CarbonIterator[Array[AnyRef]] {
    +
    +  val timeStampformatString = 
CarbonProperties.getInstance().getProperty(CarbonCommonConstants
    +    .CARBON_TIMESTAMP_FORMAT, 
CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT)
    +  val timeStampFormat = new SimpleDateFormat(timeStampformatString)
    +  val dateFormatString = 
CarbonProperties.getInstance().getProperty(CarbonCommonConstants
    +    .CARBON_DATE_FORMAT, CarbonCommonConstants.CARBON_DATE_DEFAULT_FORMAT)
    +  val dateFormat = new SimpleDateFormat(dateFormatString)
    +  val delimiterLevel1 = carbonLoadModel.getComplexDelimiterLevel1
    +  val delimiterLevel2 = carbonLoadModel.getComplexDelimiterLevel2
    +  val serializationNullFormat =
    --- End diff --
    
    make all these variables private


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to