RexXiong commented on code in PR #1798:
URL:
https://github.com/apache/incubator-celeborn/pull/1798#discussion_r1286814515
##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/readclient/FlinkShuffleClientImpl.java:
##########
@@ -177,7 +177,12 @@ protected ReduceFileGroups updateFileGroup(int shuffleId,
int partitionId) throw
} else {
// refresh file groups
ReduceFileGroups newGroups = loadFileGroupInternal(shuffleId);
- if (newGroups == null ||
!newGroups.partitionIds.contains(partitionId)) {
+ if (newGroups == null) {
+ throw new IOException(
+ "Load file group from lifecycle manager failed: "
+ + Utils.makeReducerKey(shuffleId, partitionId));
+ }
+ if (!newGroups.partitionIds.contains(partitionId)) {
Review Comment:
nit: Better use else if
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
