pan3793 commented on code in PR #1802:
URL:
https://github.com/apache/incubator-celeborn/pull/1802#discussion_r1289478070
##########
project/CelebornBuild.scala:
##########
@@ -334,14 +383,14 @@ object CelebornWorker {
.settings (
commonSettings,
libraryDependencies ++= Seq(
- "com.google.guava" % "guava" % guavaVersion,
- "commons-io" % "commons-io" % commonsIoVersion,
- "io.netty" % "netty-all" % nettyVersion,
- "org.apache.logging.log4j" % "log4j-1.2-api" % log4j2Version,
- "org.apache.logging.log4j" % "log4j-slf4j-impl" % log4j2Version,
- "org.fusesource.leveldbjni" % "leveldbjni-all" % leveldbJniVersion,
- "org.roaringbitmap" % "RoaringBitmap" % roaringBitmapVersion,
- "org.mockito" %% "mockito-scala-scalatest" % scalatestMockitoVersion %
"test",
+ Dependencies.guava,
+ Dependencies.commonsIo,
+ Dependencies.ioNetty,
+ Dependencies.log4j12Api,
Review Comment:
it's not clear to me the scope of each dep, and there is possible that a dep
may have different scopes in different modules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
